maccam912@programming.dev to Technology@lemmy.worldEnglish · 1 year agoGithub is having some issueswww.githubstatus.comexternal-linkmessage-square15fedilinkarrow-up182arrow-down12file-textcross-posted to: hackernews@derp.foo
arrow-up180arrow-down1external-linkGithub is having some issueswww.githubstatus.commaccam912@programming.dev to Technology@lemmy.worldEnglish · 1 year agomessage-square15fedilinkfile-textcross-posted to: hackernews@derp.foo
minus-squareevatroniclinkfedilinkEnglisharrow-up10arrow-down3·1 year agoNot two hours ago I declined a PR because it was a huge change on Friday.
minus-squarebamboo@lemmy.blahaj.zonelinkfedilinkEnglisharrow-up16·1 year agoWhy not just wait to merge it Monday?
minus-squareevatroniclinkfedilinkEnglisharrow-up11arrow-down1·1 year ago'cause stupid corporate policy and metrics mean an unreviewed PR is bad for me, and an unmerged PR is bad for the submitter.
minus-squarebamboo@lemmy.blahaj.zonelinkfedilinkEnglisharrow-up5·1 year agoYou’d think declined PRs would be more of a metric to deter bad PRs from happening?
minus-squareAppoxo@lemmy.dbzer0.comlinkfedilinkEnglisharrow-up8·1 year agoThis would be a logical step and we don’t do that here. Please stop being logical.
Not two hours ago I declined a PR because it was a huge change on Friday.
Why not just wait to merge it Monday?
'cause stupid corporate policy and metrics mean an unreviewed PR is bad for me, and an unmerged PR is bad for the submitter.
You’d think declined PRs would be more of a metric to deter bad PRs from happening?
This would be a logical step and we don’t do that here.
Please stop being logical.